[core] Add partition format check if partition expire time is set#7428
Merged
JingsongLi merged 3 commits intoapache:masterfrom Mar 17, 2026
Merged
[core] Add partition format check if partition expire time is set#7428JingsongLi merged 3 commits intoapache:masterfrom
JingsongLi merged 3 commits intoapache:masterfrom
Conversation
JingsongLi
reviewed
Mar 16, 2026
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Maybe we should add an option to give an option to be compatible to old version.
By default, throw exception.
Contributor
Author
User can reset partition expire related options. Because if there is exception, partition expire has no use to the user. |
Contributor
|
What if there are illegal partitions and the user only wants expired normal partitions? |
Contributor
|
A simple example is the partitioning of null values. |
Contributor
|
Even more so, I believe that the previous compatibility should not be compromised. If there are too many partitions, it should be restricted by the REST server rather than the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Users may set an incorrect partition key, or an incorrect time format for partition expire. Under such case, partitions won't expire and will increase the storage size infinitely. To avoid this problem, this PR adds a check for partition format if partition expire time is set
Tests
TableWriteTest#testPartitionTimestampValidation.API and Format
No format changes.
Documentation
Config option is added to enable this feature.
Generative AI tooling
Generated-by: qodercli 0.1.31